Skip to content

Follow changes in Offline PR 1900 - #561

Open
brownd1978 wants to merge 5 commits into
Mu2e:mainfrom
brownd1978:refregrow
Open

Follow changes in Offline PR 1900#561
brownd1978 wants to merge 5 commits into
Mu2e:mainfrom
brownd1978:refregrow

Conversation

@brownd1978

Copy link
Copy Markdown
Collaborator

This updates regrowing configuration for changes introduced in PR1900.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @brownd1978,
You have proposed changes to files in these packages:

  • JobConfig

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 33eb264: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 33eb264.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 33eb264 at e9d9adc
build (prof) Log file. Build time: 08 min 50 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO TODO (0) FIXME (0) in 0 files
clang-tidy 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 33eb264 after being merged into the base branch at e9d9adc.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian

Copy link
Copy Markdown
Collaborator

1. [S1] The new S2Resampler trajectory cuts are silently clobbered by primary/epilog.fcl — the change is a no-op.

S2Resampler.fcl sets the overrides at lines 35-36, but then includes Production/JobConfig/primary/epilog.fcl at line 58, whose line 6 is:
physics.producers.g4run.TrajectoryControl: @Local::mu2eg4DefaultTrajectories
That is a full-table assignment, and in FHiCL a later table assignment replaces the entire table — so both mcTrajectoryMomentumCut and saveTrajectoryMomentumCut are reset to the Offline default of 50 MeV/c. The job runs fine and CI stays green (nothing in the
validation suite runs S2Resampler), but the stated purpose — saving reflection trajectories down to 40 MeV/c — is not achieved.

Fix: move the two override lines below the epilog includes (after line 59). The neighboring g4run.inputs / Mu2eG4CommonCut overrides survive only because no epilog happens to touch those keys — worth a one-line comment so the next person doesn't trip on the same
layering.

2. [S2 — pre-existing, one character, please fix here] outputs.RegrowOutout.fileName typo defeats the MC output name.

recoMC/regrowLH.fcl:7 (context line right below this PR's edits) overrides RegrowOutout — the real module is RegrowOutput. The override lands on a stray table nobody references, so the MC regrow job writes rec.owner.RegrowLH.version.sequencer.art (the data-tier name
from the base fcl) instead of mcs.... — wrong data tier for SAM registration. The whole point of the recoMC wrapper is (a) the Assns override — fixed by this PR — and (b) the mcs filename — still broken. Same typo in recoMC/regrowKL.fcl:6.

3. [S2] The KL twin was left with the exact bug this PR fixes for LH.

recoMC/regrowKL.fcl:5 still says Reconstruction.producers.RegrowKL.KalSeedMCAssns : "SelectReco" — the dead prolog-table override path — so MC regrowKL still never configures its Assns. Since this PR exists to sweep up regrow config, fixing the twin
(physics.producers.RegrowKL.KalSeedMCAssns : "SelectReco" — note RegrowKinematicLine is still an EDProducer at Offline main, so it stays under producers) belongs here. For the record, reco/regrowKL.fcl itself still validates against Offline main —
RegrowKinematicLine gained no new mandatory parameters, and Mu2eKinKal.REGROW / KLDriftFit.KKFitSettings / LHDRIFTXTRAP all still exist.

4. [S3 — confirm intent] Removing drop *_*_*_Digitize is asymmetric with mixed inputs, and the surrounding keep-list is largely decorative.

  • Mixed digi files carry process name Mix, and "drop *_*_*_Mix" remains — so for a mixed input the regrow output still drops Digitize-era products (only EWM/PBI/IntensityInfo are re-kept), while an unmixed input now keeps them all (ProtonBunchTime, Digitize
    TriggerResults, trigger-merger products, ...). If regrowing mixed mcs files is in scope, the two input types now produce differently-stocked outputs — confirm that's intended.
  • Pre-existing but adjacent: Reconstruction.RegrowOutput.outputCommands has no leading "drop *_*_*_*" (unlike Reconstruction.Output), and art's default disposition is keep. So the keep sequences are mostly decorative — everything not from Mix/Reconstruct is
    kept by default, including the transient RegrowSH ComboHits from the regrow process itself. If the list is meant to be curated (its shape strongly suggests a global drop was assumed), add the leading drop; if default-keep is intended, the keeps could be pruned.

@brownd1978

Copy link
Copy Markdown
Collaborator Author

1. [S1] The new S2Resampler trajectory cuts are silently clobbered by primary/epilog.fcl — the change is a no-op.
fixed
2. [S2 — pre-existing, one character, please fix here] outputs.RegrowOutout.fileName typo defeats the MC output name.
fixed
3. [S2] The KL twin was left with the exact bug this PR fixes for LH.
fixed
4. [S3 — confirm intent] Removing drop *_*_*_Digitize is asymmetric with mixed inputs, and the surrounding keep-list is largely decorative.
fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants