Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions deploy/helm/openshell/tests/gateway_config_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,19 @@ tests:
server.oidc.issuer: https://issuer.example.com
server.oidc.caConfigMapName: openshell-oidc-ca
asserts:
- equal:
path: spec.template.spec.containers[0].volumeMounts[3].name
value: oidc-ca
- equal:
path: spec.template.spec.containers[0].volumeMounts[3].mountPath
value: /etc/openshell-tls/oidc-ca
- equal:
path: spec.template.spec.volumes[2].name
value: oidc-ca
- equal:
path: spec.template.spec.volumes[2].configMap.name
value: openshell-oidc-ca
- contains:
path: spec.template.spec.containers[0].volumeMounts
content:
name: oidc-ca
mountPath: /etc/openshell-tls/oidc-ca
any: true
- contains:
path: spec.template.spec.volumes
content:
name: oidc-ca
configMap:
name: openshell-oidc-ca
any: true

# Regression for the P1 bug Drew flagged: grpc_endpoint MUST live in the
# Kubernetes driver table, not in [openshell.gateway]. The gateway-side
Expand Down
59 changes: 30 additions & 29 deletions deploy/helm/openshell/tests/statefulset_client_ca_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,31 @@ tests:
pkiInitJob.enabled: true
certManager.enabled: false
asserts:
- equal:
path: spec.template.spec.volumes[3].name
value: tls-client-ca
- equal:
path: spec.template.spec.volumes[3].secret.secretName
value: openshell-server-tls
- equal:
path: spec.template.spec.volumes[3].secret.items[0].key
value: ca.crt
- contains:
path: spec.template.spec.volumes
content:
name: tls-client-ca
secret:
secretName: openshell-server-tls
items:
- key: ca.crt
path: ca.crt

- it: shares the cert-manager server TLS ca.crt when clientCaFromServerTlsSecret is true
template: templates/statefulset.yaml
set:
certManager.enabled: true
certManager.clientCaFromServerTlsSecret: true
asserts:
- equal:
path: spec.template.spec.volumes[3].name
value: tls-client-ca
- equal:
path: spec.template.spec.volumes[3].secret.secretName
value: openshell-server-tls
- equal:
path: spec.template.spec.volumes[3].secret.items[0].key
value: ca.crt
- contains:
path: spec.template.spec.volumes
content:
name: tls-client-ca
secret:
secretName: openshell-server-tls
items:
- key: ca.crt
path: ca.crt

# Regression: with cert-manager enabled and pkiInitJob left at its default
# `true`, the client CA condition must honor certManager precedence and NOT
Expand All @@ -54,14 +54,13 @@ tests:
certManager.clientCaFromServerTlsSecret: false
pkiInitJob.enabled: true
asserts:
- equal:
path: spec.template.spec.volumes[3].name
value: tls-client-ca
- equal:
path: spec.template.spec.volumes[3].secret.secretName
value: openshell-server-client-ca
- notExists:
path: spec.template.spec.volumes[3].secret.items
# Exact matching (without any: true) also verifies that secret.items is absent.
- contains:
path: spec.template.spec.volumes
content:
name: tls-client-ca
secret:
secretName: openshell-server-client-ca

# When cert-manager owns TLS, does not share its CA, and no separate client CA
# secret is configured, there is no client CA to mount: the volume must not
Expand All @@ -74,12 +73,14 @@ tests:
pkiInitJob.enabled: true
server.tls.clientCaSecretName: ""
asserts:
- lengthEqual:
- notContains:
path: spec.template.spec.volumes
count: 3
content:
name: tls-client-ca
any: true
- notContains:
path: spec.template.spec.containers[0].volumeMounts
content:
name: tls-client-ca
mountPath: /etc/openshell-tls/client-ca
readOnly: true
any: true
Loading