Skip to content

Fix: Update samples README using the link to the v11.0 data - #4824

Open
EstebanVg15 wants to merge 2 commits into
NVIDIA:mainfrom
EstebanVg15:release-11.2
Open

Fix: Update samples README using the link to the v11.0 data#4824
EstebanVg15 wants to merge 2 commits into
NVIDIA:mainfrom
EstebanVg15:release-11.2

Conversation

@EstebanVg15

Copy link
Copy Markdown
Contributor

Description.

  • Having the direct link in the README makes easier for automated testing jobs to download, and install the corresponding sample data to run specific tests.

  • v11.0 sample data is used as well for v11.2 samples.

 * Having the direct link in the README makes easier
   for automated testing jobs to download,
   and install the correspoding sample data to
   run specific tests.

 * v11.0 sample data is used as well for v11.2 samples.

Signed-off-by: Esteban Vazquez <esteban.vazquez@canonical.com>
@EstebanVg15
EstebanVg15 requested a review from a team as a code owner August 4, 2026 22:49

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change as #4816, reverted by the 11.2 release drop (1dade06) since samples/README.md is overwritten wholesale from the internal tree. Fine to merge, but it will regress again at 11.3 unless someone mirrors it internally — worth an NVIDIA-side owner picking that up.

Notes on lines outside the diff:

  • samples/README.md:53: Now that step 1 names the exact file, the placeholder here is stale — unzip tensorrt_sample_data_20260602.zip (or a wget <url> line above it) would make the block copy-pasteable, which is the stated point of the change.

@zeroepoch

Copy link
Copy Markdown
Contributor

Fine to merge, but it will regress again at 11.3 unless someone mirrors it internally — worth an NVIDIA-side owner picking that up.

@brnguyen2 I have an MR open to fix this internally before the next release branch is cut.

 * This makes more clear the way of downloading the zip package.

Signed-off-by: Esteban Vazquez <esteban.vazquez@canonical.com>
@EstebanVg15

Copy link
Copy Markdown
Contributor Author

Hello @zeroepoch and @brnguyen2 ,

Thanks for your quick response and feedback!

According to @brnguyen2 comments, I just pushed a commit defining a block code with the corresponding wget command, so the zip file can be easily downloaded by the users, could you please let me know if that sounds better to you? Regarding your internal changes, I can revert my last commit if needed.

@zeroepoch

Copy link
Copy Markdown
Contributor

Fine to merge, but it will regress again at 11.3 unless someone mirrors it internally — worth an NVIDIA-side owner picking that up.

@brnguyen2 I have an MR open to fix this internally before the next release branch is cut.

We merged the previous diff into upstream main. I'll work on getting this newer diff merged since it looks nicer and fits into the current flow for the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants