Skip to content

[Bug] use_single_group_runtime_offsets arg is not supported for ScaledSrelu - #3328

Merged
vthumbe1503 merged 2 commits into
NVIDIA:mainfrom
vthumbe1503:update_arg_condition
Aug 10, 2026
Merged

[Bug] use_single_group_runtime_offsets arg is not supported for ScaledSrelu#3328
vthumbe1503 merged 2 commits into
NVIDIA:mainfrom
vthumbe1503:update_arg_condition

Conversation

@vthumbe1503

Copy link
Copy Markdown
Collaborator

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
@vthumbe1503
vthumbe1503 marked this pull request as ready for review August 7, 2026 19:05
@vthumbe1503
vthumbe1503 requested a review from timmoon10 as a code owner August 7, 2026 19:05
@vthumbe1503

Copy link
Copy Markdown
Collaborator Author

/te-ci pytorch

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes single-group runtime-offset support activation-aware so ScaledSReLU avoids an unsupported cuDNN frontend argument.

  • Passes the fused activation type into runtime-offset capability checks in forward and backward grouped-MLP paths.
  • Updates the ScaledSwiGLU runtime-offset test’s helper invocation and monkeypatch signature.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
transformer_engine/pytorch/ops/fused/grouped_mlp.py Disables single-group runtime offsets for ScaledSReLU consistently across grouped-MLP forward and backward kernel setup.
tests/pytorch/test_grouped_mlp.py Adapts the existing ScaledSwiGLU runtime-offset test to the activation-aware support helper.

Reviews (2): Last reviewed commit: "Merge branch 'main' into update_arg_cond..." | Re-trigger Greptile

@zhongbozhu zhongbozhu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongbozhu

Copy link
Copy Markdown
Collaborator

/te-ci pytorch

@vthumbe1503

Copy link
Copy Markdown
Collaborator Author

Blackwell tests related to grouped mlp are passing now in CI.

@ksivaman ksivaman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman

Copy link
Copy Markdown
Member

/te-ci pytorch L0 L1

@vthumbe1503
vthumbe1503 merged commit 598b9ea into NVIDIA:main Aug 10, 2026
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants