create a the log hooks for cucascade - #175
Open
aminaramoon wants to merge 2 commits into
Open
Conversation
aminaramoon
marked this pull request as draft
July 30, 2026 23:15
aminaramoon
marked this pull request as ready for review
July 31, 2026 06:01
Contributor
Author
|
/ok to test d269f96 |
ran-yuan-rui
reviewed
Aug 4, 2026
| # topology-only build, which does not produce cucascade_objects. | ||
| if(TARGET cucascade_objects) | ||
| target_sources(cucascade_objects | ||
| PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/logging.cpp) |
Contributor
There was a problem hiding this comment.
seems like we only build logging.cpp but no stderr_sink.cpp?
ran-yuan-rui
reviewed
Aug 4, 2026
| namespace cucascade::log { | ||
| inline namespace v1 { | ||
|
|
||
| void stderr_sink(void*, record const& rec) noexcept |
Contributor
There was a problem hiding this comment.
this function has the same name within one in logging.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.