Support "version row" in vocabulary table - #803
Merged
Conversation
Permit a single row with NULL vocabulary_id to store version information for the vocabulary itself. To preserve foreign keys, replace the primary key constraint on vocabulary.vocabulary_id with a UNIQUE constraint. Rows with NULL vocabulary_id cannot be referenced by foreign keys, since NULL in a foreign key indicates the absence of a parent row. This is not a problem because the version row is not intended to be referenced. NULL handling in UNIQUE constraints differs across DBMS implementations: some allow only one NULL value, while others allow multiple. Since this table will contain only one NULL row, these differences do not affect the intended behavior. Tested only on limited set of dialects: - Postgres - Spark (using Databricks) - Redshift
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #803 +/- ##
===========================================
+ Coverage 51.51% 57.25% +5.73%
===========================================
Files 8 8
Lines 231 262 +31
===========================================
+ Hits 119 150 +31
Misses 112 112 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clairblacketer
approved these changes
Aug 14, 2026
clairblacketer
left a comment
clairblacketer
left a comment
Contributor
There was a problem hiding this comment.
This looks great, thank you @ganisimov!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permit a single row with NULL vocabulary_id to store version information for the vocabulary itself.
To preserve foreign keys, replace the primary key constraint on vocabulary.vocabulary_id with a UNIQUE constraint.
Rows with NULL vocabulary_id cannot be referenced by foreign keys, since NULL in a foreign key indicates the absence of a parent row. This is not a problem because the version row is not intended to be referenced.
NULL handling in UNIQUE constraints differs across DBMS implementations: some allow only one NULL value, while others allow multiple. Since this table will contain only one NULL row, these differences do not affect the intended behavior.
Tested only on limited set of dialects: