Skip to content

Do not mutex and let dbs clean themselves up - #437

Merged
ospfranco merged 1 commit into
mainfrom
oscar/discard-dbs-invalidation
Aug 14, 2026
Merged

Do not mutex and let dbs clean themselves up#437
ospfranco merged 1 commit into
mainfrom
oscar/discard-dbs-invalidation

Conversation

@ospfranco

@ospfranco ospfranco commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Simplifies the db clean up. The objects should be able to clean themselves up instead of relying on the global db vector. The only thing we need is the alive flag to correctly detect when to drop the ongoing async work.

opsqlite::invalidated should also be gone

@babzcraig babzcraig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Base automatically changed from pr-435-rebase to main August 14, 2026 13:44
@ospfranco
ospfranco force-pushed the oscar/discard-dbs-invalidation branch from 9ad4173 to 520d858 Compare August 14, 2026 13:44
@ospfranco
ospfranco merged commit 6cb3016 into main Aug 14, 2026
9 of 10 checks passed
@ospfranco
ospfranco deleted the oscar/discard-dbs-invalidation branch August 14, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants