Fix random Windows testsuite failures from \\?\ paths - #1618
Merged
Conversation
Path.resolve() can leave the extended-length prefix on the work dir, which cmd.exe rejects as a working directory. Use os.path.abspath() instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1618 +/- ##
=======================================
Coverage 27.23% 27.23%
=======================================
Files 69 69
Lines 13844 13844
Branches 8615 8615
=======================================
Hits 3771 3771
Misses 8881 8881
Partials 1192 1192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #1596.
Purpose
Path.resolve() can leave the extended-length prefix on the work dir, which cmd.exe rejects as a working directory.
Approach
Use os.path.abspath() instead.