Remove hiera indirector - #384
Merged
Merged
Conversation
silug
force-pushed
the
remove-hiera-indirector
branch
2 times, most recently
from
April 8, 2026 21:29
2010d3f to
c17fa45
Compare
silug
marked this pull request as ready for review
April 24, 2026 21:04
The Hiera indirector terminus has been removed as deprecated. The convert_merge method has significant branching logic that was never covered by unit tests - the deleted Puppet::Indirector::Hiera spec only exercised the shared Hiera indirection behaviours. Add explicit tests for all convert_merge branches (nil/first, unique, hash, deep, Hash with strategy, MergeStrategy delegation, and the error path) and for the :no_such_key throw in find when Hiera returns its not-found sentinel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
silug
force-pushed
the
remove-hiera-indirector
branch
from
July 7, 2026 18:13
92b455b to
bb9ff04
Compare
silug
enabled auto-merge
July 7, 2026 18:23
silug
disabled auto-merge
July 7, 2026 18:30
bastelfreak
added
the
backwards-incompatible
silug
enabled auto-merge
July 7, 2026 21:47
bastelfreak
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The Hiera indirector terminus has been removed as deprecated.
Closes #332
Checklist
I have:
Signed-off-byannotation to each of my commits