Removing old v3 unit tests - #2766
Conversation
As most tests are now in test_interpolation
As all these tests are related to old FieldSet creation API
Only tests old API for interpolators
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
some prelim feedback
| # "freeslip", | ||
| # "nearest", | ||
| # "cgrid_velocity", |
There was a problem hiding this comment.
Mainly out of curiousity: Do we have these other interpolators in v4?(/are they tested?)
There was a problem hiding this comment.
Good catch! These indeed should also be tested. I worked on it this afternoon; but it's a bit more involved than I expected. Freeslip worked out of the box, but the other two gave errors, possibly to do with the issue that @willirath found in #2801
I propose merging this PR now - and then I'll open a new issue to work on the fixes after my holidays
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good for the most part. Some small edits (including getting CI working again - some of the changed tests raise Parcels warnings which are now interpretted as failures)
2 participants
Description
This PR moves some of the last relevant tests from v3 over to the new v4 test suite, and removes the other irrelevant or already-copied tests. It also updates the interpolation_regression test
The only file that remains is tests-v3/test_reprs.py; @VeckoTheGecko, can you confirm if this test file can also go?
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None