Skip to content

Add support for Pacts#10009

Draft
Peechey wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/add-support-for-pacts
Draft

Add support for Pacts#10009
Peechey wants to merge 2 commits into
PathOfBuildingCommunity:devfrom
Peechey:feature/add-support-for-pacts

Conversation

@Peechey

@Peechey Peechey commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Adds basic support for Pacts of Beidat, Ghorr, K'Tash, and Lycia. Somewhat similar to exerted attacks, the empowered stats are scaled by uptime of the Pact against the cast time of the affected spells. I've copied the CalcSections from Exerted as well, but we probably want to adjust a few or most of those columns. Uptime and number of empowered seem most important, however.

This PR is not adding support for the Triggered sections of Pact of Ghorr nor Pact of Lycia. Godspeed to the trigger logic maniacs.
I also do not have Pact of K'Tash's Soul Gain Prevention Duration working as we calc duration sooner than we run the uptime logic. Thinking that one over a little.
This PR is not adding support for the Affliction downsides.

Added tests for UpTimeRatio validation.

Link to a build that showcases this PR:

eNrVXEtz4zYSPs_8Cpaqdk-xJFIPy1k5Kfk1dsUaayXPzO4pBZOQhAxIKCBoj_LrtwHwJVmkQJE5rA8ZiuivXwAa3QCY8a8_fGq9Yh4SFly27Ha3ZeHAZR4JVpetL893Z6PWr798HM-QWD8tryJCZcsvHz-M1bNF8Suml61-yxKIr7D4mnDq_Q6cUOjiwLumKAw_Ix9ftj6zALesDQrEGrNgSgLGPzEvee-uEUeuwPxRcp1Egk2ZByjBI2h9QYFHREL7SvCbbn2Yzp7mzy3LRyRYMPc7Fp84izZgTE4S-mNXUqbSwgV9W2DRh_GMoi3mC4GE9YpoBI32sNtv90a2M2hZIby_bE3AV2iF74lodaqCriIeihvkw2MxuN3L_yUcFhuMvUJQKmjG8e1yiV1BXvE1J-J6jQIXH8cZ0NrtHeppRAXZUIJ5MaLbTRD3R9k7du-ibZ-nMp6ZQPRmtigEdHcpmTBm_Y2I9RUFf5axt51-t911Lkb9vt3rDhPswyogApcBe73zi7bT7e8BpdDj4EOqzhgJWXCCroljjLx4HVEKM9uIdo5DzF-RIOVqFXjimvkvJDji_fYonTsco6elHtVz5JEonGLBcVjsw1TPKQrQNQvFcYsk5QxziFaiFOAM28Ps73wPvsAug3BXVWJF5CNZYnNKE6v2AVW1Oc2O24UpXWXGpyk0h7hsRrlgES0fJ-kMXghuMFJv8I9CquEom3d_lhFm7B6CktVpMMjxK6PMaffK5GQvVnHYHgx6dvd86AyHvYudAHR7PyvEXaSmzdbbkLiITtEP4kc-rBfP6DsukZgbgKu1CCB0GUNToXeE4-qoa0Y9Y5SdotaIhaawzC9yehmMxw12f5akD4FryPRLwFUUL8kqdgFzmEkyjXmh2GTF35URT0izcDLHKxzE4rZmkEeM3fUnSADnSGCDPpTR19CtkrTMrbtMDdyac9Iu4piT7LaTB1Z0k4SYuSkLpAHmq-1iTTD1qlEnal2jjaGb8-gydxeIq-SKPLSiS74h7pmtJGY62WladPuKwrIYu-cuTW3kqSmGZBcAHj6Sg3ezMoL9IYsIWg024T6LuKEFmtjIgGRx0KXTHHuRK4xcldZCVxQKQ1MzUhToSWkl6EQI5H6_Yd7K2GlKSCXErn6LaLOBCCJHwxEGZ30nv_JBFk9Mkp2M9gmGctmMzgmQi6SpgIz2qIADy76plD1ABVFq6TY2JiM-JsJ-16FTCBY-LAGq2p8yg0hzB2WbUc2mCA1rwRl7A83XckOnuMzqHaKGBMdAFY6Dv7bG_HfIjQTcBl7E5VQwlrGPyMQ8Ex_CZxjeIIGsUG0v3REqML-BHpYIJdeLM-SviBMUCFt17t5LR_c4RtxdPwL4spX_dYcofYHYAW-l4HFH7a_Jp2tE3VDp8hBsImEFatvKJ6H7-0u0XMpNMGkGVzt2t3d3t9fPD19vY_XzkPA7ofT3IPJfMG9Z-l-pk6ZcYBVUrTB6CfXjZesrwW8LibrBAhEatiyXUYo2IfYuW0tEQ5BM4FHRLMBPrijhpqgg9413wAp4ZQTFnG5_YC7AXliNXU5woV5pewkrfyPHL_ZUMC3kNEOuCI_ZpvWWC74cNUWssq2qQ4z0CnKNQqESkiKH57YDD3GRO3SFtsjGEuyDv0G0UHLcesQTYrvBIazyZElcOeHKR84zUGuqEr-4LsxQd1sybHaWv0M81KZfEQPdWAzW23CF40O3lnhV7f0VelW3FsNvsIsKbdeNxeA0x2WB3Lcu4JJSlXD6zAI1yGHuTQiVS1Vhz95SnJIUM3wSa8z1-lfIaQqhLiEpnTicvESiOBrkKEp8JQvuIg9lxfghqCoqi2zICs6DUShfaRU59H01doiVqlCK42EZVKcthf7bSYEOdoHO_4vcn68ODjohroCK7N8pkA5OEhV_J6-MeCoSFE2XPbKygAELfn02Kruvz2Y_3a_P8Y6i8Hthf8etxfAvUCESsT3ARZ_YGTGRk6oeBzm36nF4JoErIo5PZjDfT2gy7Lw8lUlS1MPg3QT2cOSIM9eTOej8-mS4Sv9PRqv4f4OXGCwoXQBSmhJDGCSFkHCog6mavBYiCm7AsQ2wUiYeDkqZpyrx0svqQa9V5qiDhd6OLo0n-R3rQkaQF9yXZJ5mnNJy-B4jKs8_Ga3HcH_bvRYzuaUXbVDgJeyeDuX7WT8Yeo-JEHiqou9G7hzW9WGA_e0BRsV6jTtJoTn-zCBHkqzl2-TH-JljbKFk48mVlaMWDz_0hYoHTxfh6swN8e0ku_4hmwJC5S2NEIrnbZzPyRo4gAIWHgajUa_3U284Gtk_9XqD7uin_mjkjHYukcQCBGiSu2jiXMgLHZHke4_CNYQBH2UXURyl5Yfxl_mjeviwFmIT_tzpvL29tTdIrNkS_yAUt13mdzYgBOw7U6XymZTTmcDf1Qr-M5jMV9Hi7BUeFcNOwnGsb52EHf1LjgdOwCbdOx3pH-Vf6UD5oGqe0PLwEkVUfML-o75EE0jFkxMwcCOEM2gMr7Y3s0XSc-GavckUQLfJwglcN3l81C2PeAUlkgSlQyaT8u8IydVaeTDuRl22C70xkRd3J5PM3aN63dcxQo0gO_asemlR9CKNkNeH5BlROtbktZxJJk7J2nunBp5qgHWYRh5-COJ9rcQM3XNj0C-5ceR0E0mfKHtB1Enk5V_ayUu5AaIHrdzNhBYVUaIgNl0qIcdW1qhezRAXmW57dqUUqvFV7_HsMvkz5_EV9mXjFAvkIYE6DwJ83ZEO7ygfwFMK7DRn7jWMuQ1EZeuOy_PqQ0YnJDHFnpk5w_YIK1o34dDh7hXHMOUMLYyH8BETvyJELeAemzQlgV7BI99nMHZna1Afhf5B2yVWQQ91ruYkTUnmSM4ZKbKiGxJcg32c7mxbzxAoebxP987WlCyjqjHKD3Cr6In3HOIAqin-D2OL3CS02NK6wpDrHZ5skuRpmRAUz7Vduoqe3QF3mrfv05pxXmJe3J5aF8_jd-bFdCdZp7F_g3G__RNtWPivZ8gkSkz8Taj2oybGdCeZqLF_g4mPW5egEuPi9qPGxXQnGaex72Z8_AgBV6VMOlWSjw--zHks_EP-IwPSNtFLJa_qjbWAHGjivco66xmqhnwWFAoSoHibSq7NaLOBsLPDQ-kap0b5qK9yLoHEDYGklauCKvFtFGJ9w-wbhlETKEQWVcYxlzhbOkINwY4yoAXM7AVyS5Ubq4MbTW451uINbazJyzYMYcnTWac1bCmITo075YyuMBX7-F4FPIysVxzuc3AqcNgxpTrOPuiCfm0T7CpOZFCr1fHiFfO2lt4NrWNJ6agYVGB0j6mPRS2XHBhX_VN6twaPEq_Wd0ZDigwb8El9Y4ZNzbtBU4wamj12A-49xTkVIBM_olhU7sITwsJpLq0cSasGzgr0c1nS2FUBTlVAr2Kga2rQNzFa7abWi17NaF97AXVqKuA04E2ndh5RPzgPmgmF9bO6YW0OdcfUoLYGJ6VTTWS3NWaHOmusP5-aMH3YAI9-7RnhnBpw67qwCfPrB4S6s6gJKxrKz5y6PTJoarmrMr0-cbSspruewv261ja2uDtNpSzVndBrSvSwsuhBZUQTOUSv8shqrJvfD7hxJ96B0leZOfLwQt04_obl5nuoz33Vvldywiuv_Fp_Meb_57J11huO2qNzcIt8EZ9Snutf_71s2ef99rB34STXmBeCX7ZcJM-GirfMlMhrFizJKt5q0z_izTalaPrGEkRQLC84qkPM1s6xY_5qsxuFgvlT5oXZVWi72_2H3PTnGIXYs6RiVijvzVpvRKytJeFYb3yGZ2cf94hRfKIuyc_Okl6ZUeTiNaMe5skt7PQrePmltrpGrK7vyp3VBabL3DXrQTEXLA_rlXsz-lH_CL2-ApzSn3e7RwBJgZcghvbF6MLENHWX4B5Ryt7k6R9F8q7D3vXxYrOSU56ZvHiRoHpHUPKKcnJNPMUcMzD_nYY5Sp66VtMN3uzr5jh928Ck-IZyCisZEwuXqSkFoyk093bus5tMSNcAVMkD0mUneCD30VEF5WSn7gsbXQyLYSFZEfq0VPfSwH_qcp2B_1wddDbYFRzRZ7LCXE1jo96S34jg5IsQs0m_WEPUrtq_u1_CVfL-_gdTRl2QBYHd-a_1nmMfqi7vajuhdGtkxCb9sPC9s_rHhkL8-R-jdI6CvPXnx5DpzeJUxa7d75k6rNjZ4066VOkbVOrXLx_Hnf3_X87_ANq46vw=

After screenshot:

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant