Fix weighted trade result parsing for 3.29#9996
Merged
LocalIdentity merged 3 commits intoJul 25, 2026
Merged
Conversation
czarandy
marked this pull request as draft
July 25, 2026 04:24
czarandy
marked this pull request as ready for review
July 25, 2026 04:30
czarandy
force-pushed
the
fix/trade-pseudo-mods-import
branch
from
July 25, 2026 04:31
94f8041 to
eb0eeea
Compare
Contributor
Author
|
Verification update:
Upstream failing run: https://github.com/PathOfBuildingCommunity/PathOfBuilding/actions/runs/30144177951 |
czarandy
force-pushed
the
fix/trade-pseudo-mods-import
branch
from
July 25, 2026 04:53
eb0eeea to
54d6771
Compare
Contributor
Author
|
ok tests are fixed now |
Contributor
Author
|
Restored the |
Closed
2 tasks
LocalIdentity
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Path of Exile 3.29 trade fetch responses return weighted
pseudoModsentries as objects, for example:{ "description": "Sum: 178", "domain": "pseudo", "hash": "stat.statgroup.0" }FetchResultBlockcurrently calls:match()directly on the first entry, causing weighted trade searches to crash. Extract the object'sdescriptionbefore matching while retaining compatibility with legacy string entries and safely handling empty arrays.Steps taken to verify a working solution:
pseudoModsarrays.Link to a build that showcases this PR:
N/A — weighted trade response parsing only.
Before screenshot:
N/A
After screenshot:
N/A