pg-tle-test: update stale PGTLE_VERSION collision comment (pgxntool#78 fixed) - #26
Open
jnasbyupgrade wants to merge 1 commit into
Open
pg-tle-test: update stale PGTLE_VERSION collision comment (pgxntool#78 fixed)#26jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
…#78 is fixed pgxntool 2.3.0 renamed the colliding variable to PGXNTOOL_PGTLE_VERSION (see the pgxntool bump this stacks on). Our own PG_TLE_BUILD_VERSION name was already independently valid and doesn't need to change, but the comment read as describing a still-open bug. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #25 (pgxntool 2.3.0 bump). Small documentation-only cleanup found while sweeping the repo for pgxntool-issue references that the 2.3.0 bump might resolve.
pgxntool#78 (the `PGTLE_VERSION` env-var collision this repo's `pg-tle-test` job worked around by using `PG_TLE_BUILD_VERSION` instead) is now fixed upstream via pgxntool#85 (renamed to `PGXNTOOL_PGTLE_VERSION`, landed in 2.3.0). Our own variable name was already independently valid and doesn't need to change - there's no bug here to fix - but the comment read as describing a still-open issue. Updated it to note the upstream fix and why we're keeping our own distinct name regardless (simplest way to guarantee no future collision with either name).
No functional change.