Add coverage for installcheck ordering and make test exit status (#79, #49) - #59
Merged
jnasbyupgrade merged 2 commits intoJul 31, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
jnasbyupgrade
marked this pull request as ready for review
July 31, 2026 19:36
1 task
jnasbyupgrade
added a commit
that referenced
this pull request
Jul 31, 2026
`test`, `results`, and `verify-results` are one tightly-coupled pipeline -- `results`/`verify-results` only exist to safely update the output `test` checks against. Per review feedback on #59, combines `test/standard/make-test.bats`, `make-results.bats`, and `test-verify-results.bats` into one file (`make-test.bats` survives, the other two are deleted), sharing a single foundation-copied environment instead of three. Also, deleted 5 dead tests (`test/output`/`test/input` directory handling) left behind when pgxntool dropped `.source` file support (issues #9/#22)
…stgres-Extensions#49) Layers on top of the make-test/results/verify-results consolidation (pgxntool-test#65, merged): adds the issue #79 structural (`make -p`) and behavioral (`make uninstall && make test`) coverage, the issue Postgres-Extensions#49 `assert_failure` regression check, and the $(TEST_DEPS)-accurate wiring comments -- all depending on the base.mk fix in the paired pgxntool branch fix-79-49 (Postgres-Extensions/pgxntool#83). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Separate what's still true today (TEST_DEPS's independent, unordered prerequisites; Make's lack of an ordering guarantee) from what was only true before this fix (installcheck having no dependency on install) -- the previous version described the old bug in present tense, reading as if it were still current behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Jul 31, 2026
…ssions (#83) `installcheck` now has an explicit `install` prerequisite, so a fresh/uninstalled tree (e.g. CI) can't run pg_regress before the extension exists. Paired test coverage: Postgres-Extensions/pgxntool-test#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired test coverage for Postgres-Extensions/pgxntool#83 (branch
fix-79-49), which fixes pgxntool issues #79, #49, and #35:installcheck: installprerequisite added so a fresh/uninstalled tree can't run pg_regress before the extension is installed (issue #79)test's recipe now exits non-zero onregression.diffsinstead of always exiting 0 (issues release skill: disambiguate placeholder tokens (VERSION, PGXNTOOL_UPSTREAM, PGXNTOOL_TEST_UPSTREAM) #49/Update stale EXTENSION_VERSION_FILES reference (rename to EXTENSION__CURRENT_VERSION__FILES) #35);results/verify-resultsnow depend on$(TEST_DEPS)directly instead oftestso the results-blessing workflow still worksRebased on top of the now-merged #65 (make-test/make-results/verify-results consolidation), so this PR's diff is now just the delta: the issue #79 coverage (a
make -p-based structural proof thatinstallis genuinely a parsed prerequisite ofinstallcheck, plus a complementarymake uninstall && make testbehavioral check with an honest caveat that it alone wouldn't have proven anything), the issue #49assert_failureregression check, and the$(TEST_DEPS)-accurate wiring comments.Test plan
test-all) run fresh against this branch + paired pgxntoolfix-79-49branch: 238/238 passed, 0 failed, 0 skipped🤖 Generated with Claude Code