commit skill: close the 'task implies a force-push' loophole - #66
Merged
jnasbyupgrade merged 1 commit intoJul 31, 2026
Merged
Conversation
The existing "never force-push without explicit ask" rule was followed right up until a task's wording implied a rebase/restructure was needed -- at which point it got treated as implicit authorization instead of a reason to stop and ask. Rewrote both the rule and the restriction to say so directly: a task implying history needs rewriting is a signal to ask, not a substitute for asking. The ask must be a literal question with a real reply, not an inference from context. Changes only in pgxntool-test. No related changes in pgxntool. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #63. That PR made the "never force-push a PR without explicit ask" rule explicit -- but it was still violated in the very same session: when a follow-up task's wording implied a branch needed rebasing onto a new base, the rule got treated as satisfied by that implication instead of by an actual explicit ask. Tightens both the Critical Requirements table and the Restrictions list to say directly: a task implying a rewrite is a signal to stop and ask, never a substitute for asking.
Changes only in pgxntool-test. No related changes in pgxntool.
Test plan
🤖 Generated with Claude Code