chore: capture iss-195 — scanner open-ended heuristic cost regression on network patterns - #208
Merged
Conversation
… on network patterns Splits the round-3 merge-gate cost finding out of iss-191 per maintainer ruling. iss-191 keeps its narrow compile-fallback scope (verified not to trigger on the bundled set); iss-195 records the reachable regression: net_ipv4/net_ipv6 classify open-ended, so every address match in ordinary content enters stolenJunctions' backward search, measured at 1.9x-27x versus the pre-iss-188 tree on reserved-documentation content. Record only; no behaviour changes. Assisted-by: Claude:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record-only: one ledger capture plus a dated
DECISIONS.mdline. No behaviour changes. Splits the round-3 merge-gate cost finding out of iss-191, per maintainer ruling (2026-08-07, interactive session).Why the split
iss-191's ledger entry describes
junctionProbe's compile-failure fallback ((?s).) — verified this session not to trigger on the bundled pattern set: the combined alternation compiles cleanly. The state-issue table had conflated that latent mechanism with the round-3 reviewer's separate, already-reachable cost finding. iss-191 keeps its narrow, still-accurate scope; the reachable half is now iss-195.What iss-195 records
The rigid/open-ended heuristic in
stolenJunctions(internal/adapter/scanner/scanner.go) skips the backward search only for patterns whose match cannot be one byte shorter.net_ipv4andnet_ipv6(internal/adapter/scanner/network.go) are variable-length, so every address they match in ordinary content enters the search — no custom config needed. Benchmarked on identical content, currentmainvs the tree immediately before the iss-188 machinery, all identifiers reserved documentation values (RFC 3849/5737/7042): neutral content 1.0×; one MAC per line 3.6× (ipv6Realso matches MAC-shaped colon-hex); one compressed IPv6 per line 1.9×; one MD5-style fingerprint per line 23×; a dense colon-hex line 27×. Reserved-rangeSkip/SkipAtfiltering runs afterscanAllPatterns, so never-reported addresses still pay. Full table and method are in the ledger entry body, since the scratch benchmark artefacts live in the ephemeral local tier.Verification
go run ./cmd/record-lintreports 0 blockers; the diff is two record files, no code.