clarify tbb install log messages#259
Merged
Merged
Conversation
'no tbb libraries found' referred only to shared libraries eligible for copying, and read as contradicting the subsequent 'creating tbb stub library (from static tbb)' on toolchains providing only a static TBB. Say 'runtime libraries' for the copy step, and consistently refer to the stub as the 'tbb.dll stub', noting what it is built from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #256/#258: on toolchains providing only a static TBB (e.g. Rtools42), the install log read as self-contradictory:
The first message referred only to shared libraries eligible for copying. Now the copy step says
no tbb runtime libraries found, and the stub messages consistently name the artifact (tbb.dll stub) and what it's built from (wrapping the oneTBB runtime/re-exporting the static tbb library).