Regenerate for purged report ids on the block result - #185
Merged
Conversation
Blocking a source graph with `purge` now reports which reports it removed, not only how many. `BlockSourceGraphResult` gains an optional `purged_report_ids`, so a caller can reconcile what left their graph instead of inferring it from a count. Additive and optional — generated tier, nothing in the facades or the integration template's emit path moves. Regenerated against RoboFinSystems/robosystems#1126; the GraphQL SDL is unchanged, so the typed GraphQL models are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blocking a source graph with
purgenow reports which reports it removed, not only how many. Regenerated against RoboFinSystems/robosystems#1126, which addspurged_report_idsto the block result so a recipient can reconcile exactly what left their graph instead of inferring it from a count.Changes
models/block_source_graph_result.py— one new optional field,purged_report_ids: list[str] | Unset, with theto_dict/from_dicthandling the generator emits for a list-typed optional. Sync and async paths are unaffected: this is a response model, not an endpoint.That is the whole diff. Nothing under
clients/(the hand-written facades) changed, and no endpoint was added, removed, or resignatured.The GraphQL SDL is unchanged —
just refresh-schemaagainst a backend running that branch reported "already current (2473 lines)", so the ariadne-codegen models are untouched. The upstream change alters authorization on existing report reads, not the schema they expose.Compatibility
ADDITIVE
Compared the emitted model before classifying, per the template's warning.
purged_report_idsis optional (| Unset, defaulting toUNSET), no existing field changed type or became required, and nothing was removed.purged_report_countis untouched and still populated, so a consumer reading only the count is unaffected.Nothing here touches the stable tier — no facade, no root export, and none of the symbols
robosystems-integration-templateimports for its emit path.Testing
just test-all— passed via the pre-commit hook: 526 passed / 17 skipped, ruff check, ruff format, basedpyright (0 errors).Release sequencing
Do not publish before robosystems#1126 merges and deploys. The field is optional, so a client ahead of the API is harmless at runtime — it simply never arrives — but until then the package would document a response field the deployed API does not return.
No version bump in this PR.