Skip to content

rspirv2 disassembly - #632

Merged
Firestar99 merged 4 commits into
mainfrom
rspirv2_dis
Aug 6, 2026
Merged

rspirv2 disassembly#632
Firestar99 merged 4 commits into
mainfrom
rspirv2_dis

Conversation

@Firestar99

@Firestar99 Firestar99 commented Jul 30, 2026

Copy link
Copy Markdown
Member

We released rspirv2 🎉

  • best reviewed commit by commit
  • last commit "switch dis preset to default" has a ton of bless changes that don't need to be reviewed, since I'm only changing the disassembly settings for prettier disassembly
  • rather, review the blesses in "replace disassembler*" where actual differences between rspirv and rspirv2 are visible
  • while you're reviewing this, please also approve ci: split compiletest target-envs into steps #533

@Firestar99
Firestar99 force-pushed the rspirv2_dis branch 2 times, most recently from f6f9bea to 7d58b22 Compare July 30, 2026 13:45
@Firestar99
Firestar99 marked this pull request as ready for review July 31, 2026 09:34
Comment thread crates/rustc_codegen_spirv/src/codegen_cx/mod.rs Outdated
Comment thread crates/rustc_codegen_spirv/src/codegen_cx/mod.rs Outdated
Comment thread crates/rustc_codegen_spirv/src/codegen_cx/mod.rs Outdated
@Firestar99
Firestar99 force-pushed the rspirv2_dis branch 2 times, most recently from df2e6df to ae13751 Compare August 4, 2026 10:14

@LegNeato LegNeato left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what is going on now.

@Firestar99

Copy link
Copy Markdown
Member Author

Wrong lockfiles twice...

@Firestar99
Firestar99 added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit 9453497 Aug 6, 2026
23 checks passed
@Firestar99
Firestar99 deleted the rspirv2_dis branch August 6, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants