Modify corrected OpFlash to include particle and photon propagation time - #176
Open
asanchezcastillo wants to merge 1 commit into
Open
Modify corrected OpFlash to include particle and photon propagation time#176asanchezcastillo wants to merge 1 commit into
asanchezcastillo wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the sbn::CorrectedOpFlashTiming data object to record the particle and photon propagation times used during flash-time corrections, enabling downstream consumers to access the correction components explicitly.
Changes:
- Added
ParticlePropagationTimeandPhotonPropagationTimefields tosbn::CorrectedOpFlashTiming. - Updated the ROOT dictionary schema version entries for
sbn::CorrectedOpFlashTiminginclasses_def.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sbnobj/Common/Reco/CorrectedOpFlashTiming.h | Adds new timing fields to persist particle/photon propagation components used in corrected flash timing. |
| sbnobj/Common/Reco/classes_def.xml | Bumps schema version metadata for sbn::CorrectedOpFlashTiming to support ROOT I/O for the updated layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+318
to
321
| <class name="sbn::CorrectedOpFlashTiming" ClassVersion="18"> | ||
| <version ClassVersion="18" checksum="1139303800"/> | ||
| <version ClassVersion="17" checksum="1139303800"/> | ||
| <version ClassVersion="16" checksum="1734226620"/> |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror PR of #175 to production branch.
To be merged with:
SBNSoftware/sbndcode#949
SBNSoftware/sbncode#668
SBNSoftware/sbnanaobj#197