fix bug with quoted identifiers in ALTER SESSION SET - #5670
Open
korbash wants to merge 1 commit into
Open
Conversation
|
|
Collaborator
|
@korbash can you add tests? |
StuffbyYuki
self-requested a review
July 15, 2026 15:31
Collaborator
|
@korbash Following up on my prev message |
Author
|
@StuffbyYuki Sorry for the late response. I’m not really like my solution because I moved dialect-specific logic out of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5666
This fix looks pretty bad because it moves Snowflake-specific logic out of
engine_adapter/snowflake.py. But anyway, it highlighted the problem, and it works. I hope it doesn't have side effects, but I'm not sure.