fix(sources): cap compressed and decompressed payload size to prevent OOM - #134
Open
harshvardhan-s1 wants to merge 5 commits into
Open
fix(sources): cap compressed and decompressed payload size to prevent OOM#134harshvardhan-s1 wants to merge 5 commits into
harshvardhan-s1 wants to merge 5 commits into
Conversation
…nt and connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources that decompress untrusted input fed client-controlled payloads into
unbounded
read_to_endcalls, letting a small upload drive an arbitrarily largeallocation and OOM-kill the daemon. Port upstream's
CappedDecoder(vectordotdev/vector#25819, commit 3162ed1a2e) into
vector-commonand apply itat every affected call site.
The cap defaults to 100 MiB and is tunable with
--max-decompressed-size-bytes/VECTOR_MAX_DECOMPRESSED_SIZE_BYTES. Oversized payloads are rejected rather thanbuffered. For zstd the decoder window is clamped as well, since a crafted frame
allocates its window before emitting any output and so escapes an output-size
cap entirely; under HTTP the clamp follows RFC 9659's 8 MB ceiling.
Tickets fixed: