Swift/Kotlin alignment: discard preload cache on configuration changes - #680
Open
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Package Size
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
force-pushed
the
preload-configuration-invalidation
branch
from
August 19, 2026 15:53
9280826 to
d50a79a
Compare
kieran-osgood-shopify
force-pushed
the
preload-configuration-invalidation
branch
from
August 20, 2026 10:44
d50a79a to
2269a24
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/680
to
kieran-osgood/08-20-fixswiftuimodifiersshouldbeinstancescoped
August 20, 2026 10:44
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
kieran-osgood-shopify
force-pushed
the
preload-configuration-invalidation
branch
from
August 20, 2026 10:46
2269a24 to
2d32510
Compare
kieran-osgood-shopify
force-pushed
the
preload-configuration-invalidation
branch
from
August 20, 2026 11:57
2d32510 to
a9f5fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TLDR
This PR fixes a bug in swifts preload cache invalidation after configuration changes, as well as aligns the implementation otherwise to Kotlins
Details
I observed a fork in behaviour between Swift and Kotlin
Kotlin discards the CheckoutWebView cache on each configuration change (
ShopifyCheckoutKit.configure {})Swift only invalidated after configuration changes if
preloadinghad changedThats the divergent behaviour
The bug is that other properties in configuration drive behaviour of preload, not responding to these means the preload is actually stale
appearance(visual)platform(drives user agent)Approach Rationale
I considered updating the swift side to additionally check for appearance and storefront changes to keep this atomic, however opted to match to kotlins for these reason:
ShopifyCheckoutKit.configure {}calls / direct mutation viaShopifyCheckoutKit.configurationwill always discard preloaded checkouts"Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.