Fix rename from constant definition sites - #4176
Open
Guflly wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4090.
Constant assignments and multi-assignment targets are valid rename origins, but they were excluded from both rename request node filters.
Implementation
Include
ConstantWriteNodeandConstantTargetNodein rename lookup and constant name resolution.prepareRenameusesname_locfor constant writes so the returned range covers only the name.Automated Tests
Added coverage for preparing and applying renames from direct assignments and multi-assignment targets. The focused rename, prepare-rename, and index tests pass.
Manual Tests
Not run; the request behavior is covered by the automated tests.