Re-regenerate global binstubs when Ruby version changes - #4177
Open
vinistock wants to merge 2 commits into
Open
Conversation
vinistock
added
bugfix
rafaelfranca
approved these changes
Jul 27, 2026
rafaelfranca
approved these changes
Jul 27, 2026
rafaelfranca
approved these changes
Jul 27, 2026
st0012
approved these changes
Jul 27, 2026
larister
approved these changes
Jul 28, 2026
larister
left a comment
larister
left a comment
There was a problem hiding this comment.
Thanks for sorting this @vinistock!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RubyGems installs executable binstubs that sometimes bake the Ruby version. When the Ruby version for the project is updated, if the version manager reuses that path for any reason, we crash on boot because the baked version doesn't match the one actually being used.
Implementation
The fix is to invoke
gem pristine ruby-lsp --only-executables --env-shebangwhen Ruby gets upgraded. To achieve that, we need to remember a slightly more complex update state, so that this is triggered not only when a certain amount of time passed, but when Ruby gets an upgrade too.FYI: I cut v0.10.5-preview to test out the changes before cutting a stable release.