Skip to content

Handle missing Gemfile in project add-on loading - #4178

Merged
vinistock merged 1 commit into
mainfrom
vs_avoid_failing_load_addon_without_gemfile
Jul 27, 2026
Merged

Handle missing Gemfile in project add-on loading#4178
vinistock merged 1 commit into
mainfrom
vs_avoid_failing_load_addon_without_gemfile

Conversation

@vinistock

Copy link
Copy Markdown
Member

Motivation

We were unconditionally invoking Bundler.bundle_path to filter project add-ons, but that actually raises when opening the LSP in a project with no Gemfile.

Implementation

We need to rescue and ensure that we don't crash when loading project add-ons.

Automated Tests

Added a test to avoid regressions.

@vinistock vinistock self-assigned this Jul 27, 2026
@vinistock vinistock added the bugfix This PR will fix an existing bug label Jul 27, 2026
@vinistock
vinistock requested a review from a team as a code owner July 27, 2026 18:58
@vinistock vinistock added the server This pull request should be included in the server gem's release notes label Jul 27, 2026
@vinistock
vinistock enabled auto-merge (squash) July 27, 2026 19:01
@vinistock
vinistock merged commit a1add9e into main Jul 27, 2026
40 checks passed
@vinistock
vinistock deleted the vs_avoid_failing_load_addon_without_gemfile branch July 27, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants