docs: add design for flow/permission-set-assignment cleanup - #132
Merged
Conversation
Design for replacing the deleteFlows.mjs/deletePermissionSetAssignments.mjs/ deleteObsoleteFlowVersions.mjs scripts with sf simply flow delete, sf simply flow version prune, and sf simply permissions assignment delete. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design doc for replacing three bespoke, per-customer-repo Node scripts (
deleteFlows.mjs,deletePermissionSetAssignments.mjs,deleteObsoleteFlowVersions.mjs) with proper commands in thismonorepo:
sf simply flow delete— newsimply-flowpackage. Deactivates and hard-deletes every version ofthe Flows named in a
destructiveChanges.xml(or via explicit--flow-nameflags) — requiredbefore a destructive metadata deploy can remove a Flow that still has an active version.
sf simply flow version prune— same new package. Deletes obsolete Flow versions for flows foundunder
--source-dir, with a--dry-runpreview the original script never had.sf simply permissions assignment delete— new command in the existingsimply-permissionspackage. Deletes
PermissionSetAssignments for permission sets/groups named in adestructiveChanges.xml, so their own destructive deploy doesn't fail or orphan assignments.Also proposes a new
simply-corehelper,readPackageManifestMembers, so both--file-readingcommands share one parser for the
<types><name>/<members></types>shape instead of each rollingtheir own — and fixes a real SOQL-injection gap in the originals (unescaped string interpolation into
IN (...)clauses) by reusingsimply-core's existingchunkedInQuery/escapeSoqlLiteral.This is a design-only PR — no implementation yet. Rationale for the package split (new
simply-flowvs. folding into
simply-cicd) and theflow deletevs.flow version prunenaming asymmetry are bothrecorded in the doc's Alternatives Considered section.
Test plan
N/A — documentation only, no code changes.
🤖 Generated with Claude Code