Hager WAASYS device support#3104
Merged
hcarter-775 merged 1 commit intoJul 15, 2026
Merged
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f744eca |
JanJakubiszyn
force-pushed
the
Haager_WAASYS_device_support
branch
from
July 8, 2026 14:30
f356ab8 to
6840215
Compare
JanJakubiszyn
changed the title
Contributor
Author
|
Reference to the previous PR: [https://github.com//pull/2858] |
hcarter-775
reviewed
Jul 8, 2026
|
|
||
| function Descriptor:get_attribute_by_id(attr_id) | ||
| local attr_id_map = { | ||
| [0x0000] = "DeviceTypeList", |
Contributor
There was a problem hiding this comment.
We should still ensure this actually points to something
Contributor
There was a problem hiding this comment.
You can test that this will work by pointing your local lua libs to 0.58. Currently, if you do that, the tests will crash
hcarter-775
reviewed
Jul 8, 2026
| end | ||
|
|
||
| Descriptor.attribute_direction_map = { | ||
| ["DeviceTypeList"] = "server", |
Contributor
There was a problem hiding this comment.
To actually use this def, we'll need to conditionally include it in your init.lua file. See how this is done in the main driver for examples.
hcarter-775
reviewed
Jul 8, 2026
| @@ -1,4 +1,4 @@ | |||
| -- Copyright © 2025 SmartThings, Inc. | |||
Contributor
There was a problem hiding this comment.
we should leave this as 2025
Contributor
Author
There was a problem hiding this comment.
Will do in tomorrow's update to the PR.
JanJakubiszyn
force-pushed
the
Haager_WAASYS_device_support
branch
from
July 8, 2026 18:04
6840215 to
19d6fc4
Compare
JanJakubiszyn
force-pushed
the
Haager_WAASYS_device_support
branch
8 times, most recently
from
July 15, 2026 08:34
9448546 to
4f43bf0
Compare
|
Channel deleted. |
JanJakubiszyn
force-pushed
the
Haager_WAASYS_device_support
branch
from
July 15, 2026 14:38
4f43bf0 to
f744eca
Compare
hcarter-775
approved these changes
Jul 15, 2026
hcarter-775
left a comment
hcarter-775
left a comment
Contributor
There was a problem hiding this comment.
Packaging now works in production. Regression tested against 0.58 lua libs. Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests