fix(mongodb): implement dropObjectStatement to support dropping collections from UI - #2582
Open
0xRahad wants to merge 2 commits into
Open
fix(mongodb): implement dropObjectStatement to support dropping collections from UI#25820xRahad wants to merge 2 commits into
0xRahad wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88ccb8189d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes the issue where dropping a MongoDB collection from the sidebar UI failed with the error:
Root Cause
Collection drop requests from the sidebar route through
batchToggleDelete→TableOperationSQLBuilder.dropObjectStatement→PluginDriverAdapter.dropObjectStatement. When the underlying plugin does not implementdropObjectStatement, it defaults to the generic SQL fallback (DROP <objectType> <name>). BecauseMongoDBPluginDriverdid not implement this method, it produced raw SQL (DROP TABLE "<name>"), which was rejected byMongoShellParser.Solution
dropObjectStatementinMongoDBPluginDriverto returndb.<collection>.drop(), enabling proper execution through the embeddedmongoshruntime.testDropTableFallbackIsRejectedinMongoShellParserTests.Verification
MongoDBDriverand the fullTableProtarget in Debug configuration.MongoShellParserTestsandPluginDriverAdapterTableOpsTests.Closes #2581