perf(router-core): inline buildWithMatches inside buildLocation - #8070
Conversation
|
View your CI Pipeline Execution ↗ for commit f95b57c
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview4 package(s) bumped directly, 19 bumped as dependents. 🟩 Patch bumps
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesLocation mask handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized performance refactor is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will degrade performance by 8.24%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | mem server error-paths unmatched (vue) |
625 KB | 583.9 KB | +7.04% |
| ⚡ | Simulation | client-search-params navigation loop (react) |
177.3 ms | 168.4 ms | +5.31% |
| ⚡ | Simulation | client-async-pipeline navigation loop (react) |
103.9 ms | 99.4 ms | +4.58% |
| ⚡ | Memory | mem server aborted-requests (solid) |
1.3 MB | 1.2 MB | +4.27% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
340.7 KB | 328.1 KB | +3.86% |
| ⚡ | Simulation | ssr request loop (solid) |
446.1 ms | 429.8 ms | +3.79% |
| 👁 | Simulation | ssr control-flow error 500 (react) |
229.1 ms | 240.4 ms | -4.7% |
| 👁 | Simulation | ssr control-flow route headers (react) |
296.1 ms | 311.6 ms | -5% |
| 👁 | Memory | mem server error-paths redirect (solid) |
379.7 KB | 392.8 KB | -3.32% |
| 👁 | Memory | mem server error-paths unmatched (solid) |
541.8 KB | 574.6 KB | -5.71% |
| 👁 | Memory | mem server peak-large-page (solid) |
1.1 MB | 1.1 MB | -5.07% |
| 👁 | Memory | mem server error-paths not-found (react) |
382 KB | 431.7 KB | -11.52% |
| 👁 | Memory | mem server error-paths redirect (react) |
305.5 KB | 320.9 KB | -4.8% |
| 👁 | Memory | mem server peak-large-page (react) |
1.1 MB | 2.3 MB | -50.04% |
| 👁 | Memory | mem server server-fn-churn (react) |
376.3 KB | 395.9 KB | -4.94% |
| 👁 | Memory | mem server aborted-requests (vue) |
1 MB | 1.1 MB | -3.84% |
| 👁 | Memory | mem server error-paths error (vue) |
940.9 KB | 2,301 KB | -59.11% |
| 👁 | Simulation | client-nested-params navigation loop (react) |
212.8 ms | 228.1 ms | -6.7% |
| 👁 | Memory | mem client preload-churn (vue) |
758.5 KB | 884.8 KB | -14.27% |
| 👁 | Memory | mem client unique-location-churn (vue) |
614.2 KB | 546.3 KB | +12.43% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf-router-core-inline-build-with-matches (f95b57c) with main (cf6ab17)
Summary by CodeRabbit
Bug Fixes
Tests
Chores