feat: consolidate pipeline validation#30
Merged
Volv-G merged 1 commit intoJul 15, 2026
Merged
Conversation
Move graph-shape, vendored JSON schema, and component-input validation into tangle-cli so pipeline validation, pipeline-run submit/dry-run, and PipelineRunner share one validation surface. Deduplicate validation so each path validates once, add the vendored schema/refresh helper and jsonschema dependency, preserve tangle_cli.pipelines re-exports for back-compat, and bump tangle-cli to 0.1.4. Assisted-By: devx/5490f7cb-c7e4-4cf5-b525-a8c4e2af55b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates Tangle pipeline validation into OSS
tangle-cliso local authoring and submit paths share the same checks:tangle sdk pipelines validatetangle sdk pipeline-runs submit/--dry-runPipelineRunner.run_pipelineThe shared validator now covers graph shape, the packaged Tangle pipeline JSON schema, and component-input wiring when component specs are available. Submit validation remains post-hydration by default;
--no-hydratevalidates the as-is spec.Motivation
tangle-deployhad duplicated generic pipeline validators that belong in the OSS CLI. Moving the generic validation surface here letstangle-clireject malformed pipelines consistently before API submission while avoiding runtime schema fetching or executing upstream source code.What changed
tangle_cli.pipeline_validationfor:tangle_cli.pipeline_spec_utils.tangle_cli.pipelinesso existing imports continue to work.tangle_cli/schemas/pipeline_schema.jsonand addedscripts/refresh_pipeline_schema.pyfor manual regeneration.exec()of upstream schema code.jsonschemaas a coretangle-clidependency.PipelineRunManagerchoke point.PipelineRunnervalidation so high-level runner usage validates once, while direct/base submit paths still validate once.tangle-clifrom0.1.3to0.1.4.Test plan
uv run --frozen pytest -q→705 passed, 4 warningsuv run --frozen ruff check scripts/refresh_pipeline_schema.py packages/tangle-cli/src/tangle_cli/__init__.py packages/tangle-cli/src/tangle_cli/pipeline_run_manager.py packages/tangle-cli/src/tangle_cli/pipeline_runner.py packages/tangle-cli/src/tangle_cli/pipelines.py packages/tangle-cli/src/tangle_cli/pipeline_spec_utils.py packages/tangle-cli/src/tangle_cli/pipeline_validation.py tests/test_packaging.py tests/test_pipeline_runs_cli.py tests/test_pipelines_cli.py→ passedgit diff --check→ passed--no-hydrategraphsdefault: nullnow satisfies default semantics consistently with submit conversionNotes / follow-ups