Skip to content

Use typing.Self and drop typing_extensions in automatic_differentiation - #15114

Merged
cclauss merged 1 commit into
TheAlgorithms:masterfrom
priya-sundaram-dev:ta-self-typing
Aug 28, 2026
Merged

Use typing.Self and drop typing_extensions in automatic_differentiation#15114
cclauss merged 1 commit into
TheAlgorithms:masterfrom
priya-sundaram-dev:ta-self-typing

Conversation

@priya-sundaram-dev

Copy link
Copy Markdown
Contributor

Re-opening the automatic_differentiation.py change from #15113 as its own PR (no uv.lock), per @cclauss's request.

machine_learning/automatic_differentiation.py was the only module importing Self from typing_extensions, behind a # noqa: UP035. Since the repo requires Python >=3.14, typing.Self (added in 3.11) is always available — so it now imports from the stdlib and the noqa is removed (UP035 stays enforced). Verified: 13 doctests pass, ruff check clean.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. If not, please split into separate PRs.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.

`machine_learning/automatic_differentiation.py` was the only module
importing `Self` from `typing_extensions`, behind a `# noqa: UP035`.
Since the repo requires Python >=3.14, `typing.Self` (added in 3.11)
is always available, so import it from the stdlib and drop the noqa.

### Describe your change:

* [x] Add an algorithm?
* [ ] Fix a bug or typo in an existing algorithm?
* [ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
* [ ] Documentation change?

### Checklist:

* [x] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md).
* [x] This pull request is all my own work -- I have not plagiarized.
* [x] I know that pull requests will not be merged if they fail the automated tests.
* [x] This PR only changes one algorithm file. If not, please split into separate PRs.
* [x] All new Python files are placed inside an existing directory.
* [x] All filenames are in all lowercase characters with no spaces or dashes.
* [x] All functions and variable names follow Python naming conventions.
* [x] All function parameters and return values are annotated with Python type hints.
* [x] All functions have doctests that pass the automated testing.
* [x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 28, 2026
@cclauss
cclauss enabled auto-merge (squash) August 28, 2026 23:03
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Aug 28, 2026
@cclauss
cclauss merged commit f3f599a into TheAlgorithms:master Aug 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants