Fix StringFormatInvalid lint errors in translated strings - #691
Merged
Conversation
Five app_eula translations (da, eu, fi, nl, no) had a literal "100%" followed by a letter lint's formatter parser treats as a conversion character (e.g. "% b", "% s"), making the string an invalid format spec; escape the percent sign as "%%" in each. The Slovenian msg_wg_mullvad_countries_failed string was empty, dropping the required %s placeholder from its source counterpart entirely; added a translation with the placeholder restored. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M5uW2XvYGhBTBE19Nsod6z
kasnder
marked this pull request as ready for review
July 28, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:app:lintGithubDebugwas failing with 6StringFormatInvaliderrors, all pre-existing in translatedstrings.xmlfiles, unrelated to any in-flight changes.app_eulatranslations (da, eu, fi, nl, no) contain a literal100%immediately followed by a letter (e.g.b,s) that lint's JavaFormatterparser reads as a conversion character, producing an invalid format spec like% b. Escaped the%as%%in each so it's treated as a literal percent sign.msg_wg_mullvad_countries_failedstring was empty, silently dropping the%splaceholder required by the code that callsgetString(R.string.msg_wg_mullvad_countries_failed, ex.getMessage())(ActivityWireGuardProfiles.java:187). Added a translation with the placeholder restored, following the phrasing of the neighboringmsg_wg_mullvad_failedstring.Test plan
./gradlew :app:lintGithubDebug— 0 errors (was 6), 512 warnings (unchanged)🤖 Generated with Claude Code
https://claude.ai/code/session_01M5uW2XvYGhBTBE19Nsod6z
Generated by Claude Code