Add initial support for MoP Classic 5.5.4#994
Open
gonzo1247 wants to merge 3 commits into
Open
Conversation
Most opcode values and update field definitions for 5.5.4 are still missing. - Correct the SMSG_SPELL_START reader - Fix SMSG_ON_MONSTER_MOVE parsing Added builds: 5.5.4.67849 5.5.4.68042 5.5.4.68077 5.5.4.68159 5.5.4.68317 5.5.4.68571
…into 554Version # Conflicts: # WowPacketParser/Enums/ClientVersionBuild.cs # WowPacketParser/Enums/Version/UpdateFields.cs # WowPacketParser/Misc/ClientVersion.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for MoP Classic 5.5.4.
The currently defined opcode values were identified and verified through packet capture analysis. Most opcode values for 5.5.4 are still unknown and therefore remain missing.
Update field definitions for 5.5.4 are also not included yet.
Changes:
SMSG_SPELL_STARTreaderSMSG_ON_MONSTER_MOVEparsingKnown limitations: