fix(setup): combine recommended plugin actions - #1677
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe recommended plugin wizard now combines installation and network activation into one step per plugin. Queue processing handles both operations, reports errors, and advances consistently. Wizard copy and tests were updated for active-plugin completion and combined success messages. ChangesRecommended plugin installation flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SetupWizard
participant Installer
participant Activation
SetupWizard->>Installer: Install selected plugin
Installer-->>SetupWizard: Return success or error
SetupWizard->>Activation: Activate configured plugin across network
Activation-->>SetupWizard: Return activation result
SetupWizard->>SetupWizard: Mark row complete and process next item
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@inc/installers/class-recommended-plugins-installer.php`:
- Around line 51-52: Update all three activation actions in
inc/installers/class-recommended-plugins-installer.php at lines 51-52, 70-71,
and 85-86 to pass true as the third argument to activate_plugin(), ensuring each
recommended plugin is activated network-wide; add coverage verifying network
activation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 62bde238-4b61-417a-8555-c680deac98dc
📒 Files selected for processing (5)
assets/js/setup-wizard.jsinc/admin-pages/class-setup-wizard-admin-page.phpinc/installers/class-recommended-plugins-installer.phptests/WP_Ultimo/Admin_Pages/Setup_Wizard_Admin_Page_Test.phptests/WP_Ultimo/Installers/Recommended_Plugins_Installer_Test.php
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
superdav42
added
the
review-feedback-scanned
1 participant
Summary
Verification
vendor/bin/phpunit --filter 'Recommended_Plugins_Installer_Test|Setup_Wizard_Admin_Page_Test'vendor/bin/phpcs inc/admin-pages/class-setup-wizard-admin-page.php inc/installers/class-recommended-plugins-installer.php tests/WP_Ultimo/Admin_Pages/Setup_Wizard_Admin_Page_Test.php tests/WP_Ultimo/Installers/Recommended_Plugins_Installer_Test.phpvendor/bin/phpstan analyse inc/admin-pages/class-setup-wizard-admin-page.php inc/installers/class-recommended-plugins-installer.phpnode_modules/.bin/eslint assets/js/setup-wizard.jsaidevops.sh v3.32.188 plugin for OpenCode v1.18.5 with gpt-5.6-sol spent 15m and 223,072 tokens on this with the user in an interactive session.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests