Skip to content

fix(settings): show direct API keys after toggle - #1678

Merged
superdav42 merged 1 commit into
mainfrom
feature/auto-20260728-151052
Jul 28, 2026
Merged

fix(settings): show direct API keys after toggle#1678
superdav42 merged 1 commit into
mainfrom
feature/auto-20260728-151052

Conversation

@superdav42

@superdav42 superdav42 commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Normalize scalar Vue settings values before evaluating field visibility requirements.
  • Restore Stripe direct API-key inputs immediately after enabling the advanced toggle.

Verification

  • eslint assets/js/vue-apps.js
  • Targeted scalar/array requirement regression assertion
  • vendor/bin/phpunit --filter Stripe_OAuth_Test

aidevops.sh v3.32.191 plugin for OpenCode v1.18.5 with gpt-5.6-terra

Summary by CodeRabbit

  • Bug Fixes
    • Improved comparisons for string, number, and boolean values, ensuring equivalent primitive values are matched consistently.
    • Preserved strict comparison behavior for other value types.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f9619c6-7fe2-41f6-8a30-52b6c6361925

📥 Commits

Reviewing files that changed from the base of the PR and between 65e2b97 and e229871.

📒 Files selected for processing (1)
  • assets/js/vue-apps.js

📝 Walkthrough

Walkthrough

The require(data, value) helper now treats string, number, and boolean values as equal when their string representations match, while retaining strict equality for other type combinations.

Changes

Primitive comparison matching

Layer / File(s) Summary
Require primitive equality
assets/js/vue-apps.js
require(data, value) compares string, number, and boolean values after converting both to String; other combinations use strict equality.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: vuckro

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches one visible outcome of the PR by referencing settings visibility and the API-key toggle behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-20260728-151052

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42
superdav42 merged commit 3505cdb into main Jul 28, 2026
11 checks passed
@superdav42

Copy link
Copy Markdown
Collaborator Author

Summary

  • Normalize scalar Vue settings values before evaluating field visibility requirements.
  • Restore Stripe direct API-key inputs immediately after enabling the advanced toggle.

Verification

  • eslint assets/js/vue-apps.js
  • Targeted scalar/array requirement regression assertion
  • vendor/bin/phpunit --filter Stripe_OAuth_Test

aidevops.sh v3.32.191 plugin for OpenCode v1.18.5 with gpt-5.6-terra


Merged via PR #1678 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

@superdav42 superdav42 added the review-feedback-scanned Merged PR already scanned for quality feedback label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-feedback-scanned Merged PR already scanned for quality feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant