Skip Codecov upload for dependabot PRs - #305
Merged
Merged
Conversation
Dependabot-triggered workflow runs never receive repository secrets, so CODECOV_TOKEN is empty and the upload step fails with "Token required because branch is protected" (fail_ci_if_error: true), taking down the whole unit-tests job even though pytest itself passed. Same root cause and fix pattern as the docker job in #304. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CODECOV_TOKENis empty inunit_tests.yml, and the Codecov upload step fails withToken required because branch is protected(fail_ci_if_error: true). This takes down the wholeunit-testsjob even though pytest itself passes — visible on nearly every open dependabot PR (e.g. Bump pymdown-extensions from 10.21.3 to 11.0.1 #301, Bump gitpython from 3.1.50 to 3.1.58 #300, Bump cryptography from 48.0.1 to 50.0.0 #299, Bump aiohttp from 3.14.1 to 3.14.3 #298, Bump ray from 2.55.0 to 2.56.0 #294, Bump pyasn1 from 0.6.3 to 0.6.4 #292, Bump pillow from 12.2.0 to 12.3.0 #291, Bump actions/setup-python from 6 to 7 #290, Bump mcp from 1.27.0 to 1.28.1 #288, Bump actions/checkout from 6.0.3 to 7.0.1 #282), and is why they still show a red "unit-tests" check after rebasing onto the Skip docker build/push job for dependabot PRs #304 fix.github.actor == 'dependabot[bot]', same pattern as the docker job fix.Test plan
main