Skip to content

Allow atomic operations on non-shared memory in SafeHeap #8890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschuff merged 2 commits into from
Jul 14, 2026
Merged

Allow atomic operations on non-shared memory in SafeHeap #8890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02003f3
Allow atomic operations on non-shared memory in SafeHeap
dschuff Jul 9, 2026
aef7ee6
clamg-format
dschuff Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/passes/SafeHeap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,8 @@ struct SafeHeap : public Pass {
}
}

bool
isPossibleAtomicOperation(Index align, Index bytes, bool shared, Type type) {
return align == bytes && shared && type.isInteger();
bool isPossibleAtomicOperation(Index align, Index bytes, Type type) {
return align == bytes && type.isInteger();
}

void addGlobals(Module* module, FeatureSet features) {
Expand Down Expand Up @@ -264,8 +263,8 @@ struct SafeHeap : public Pass {
for (MemoryOrder memoryOrder : memoryOrdersToGenerate) {
load.order = memoryOrder;
if (load.isAtomic() &&
!isPossibleAtomicOperation(
align, bytes, module->memories[0]->shared, type)) {
(!features.hasAtomics() ||
!isPossibleAtomicOperation(align, bytes, type))) {
continue;
}
addLoadFunc(load, module);
Expand Down Expand Up @@ -300,8 +299,8 @@ struct SafeHeap : public Pass {
for (auto memoryOrder : memoryOrdersToGenerate) {
store.order = memoryOrder;
if (store.isAtomic() &&
!isPossibleAtomicOperation(
align, bytes, module->memories[0]->shared, valueType)) {
(!features.hasAtomics() ||
!isPossibleAtomicOperation(align, bytes, valueType))) {
continue;
}
addStoreFunc(store, module);
Expand Down
Loading
Loading