Run install() downloads in parallel instead of blocking the main thread. - #200
Open
padenot wants to merge 2 commits into
Open
Run install() downloads in parallel instead of blocking the main thread.#200padenot wants to merge 2 commits into
padenot wants to merge 2 commits into
Conversation
Step 6 queued a task on the relevant global object's task queue that then waited for the language pack downloads to complete, which stalls script on the main thread. Move the download initiation and the wait into an [=in parallel=] block, and queue a task only to resolve the promise. Fixes #199
The prose already states the promise resolves to false if options.langs is empty, but no step implemented it: an empty sequence vacuously passes the unsupported-language check and then trivially succeeds with no downloads, resolving to true. Add an explicit step, matching how the availability algorithm treats an empty sequence as unavailable.
Member
Author
|
Added another commit that fixes a mistake in the prose, but it was clear what to do. |
evanbliu
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 6 queued a task on the relevant global object's task queue that then waited for the language pack downloads to complete, which stalls script on the main thread. Move the download initiation and the wait into an [=in parallel=] block, and queue a task only to resolve the promise.
Fixes #199
Preview | Diff