Bound SAS format suffix writes - #385
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readstat_variable_t.formatRoot cause
snprintf()returns the number of bytes it wanted to write, even when the destination truncates the result. A near-full 256-byte format can therefore advancelenpast the array before the digit suffix is appended, producing an out-of-bounds pointer and an underflowed remaining size.This fixes the publicly disclosed OSV-2026-634 / OSS-Fuzz issue 506459940. The exact testcase previously reported
index 257 out of bounds for type char[256]insas7bdat_init_variable().Verification
make check: 4/4 tests passed under ASan/UBSan5180794695122944(SHA-25612128ef78252314bc605bc6c8236383caffff420be659e6b466b33dfb54e6136): clean under ASan/UBSan after the fixgit diff --check