Block Supports: Ensure that custom CSS is output after the block library styles.#12461
Closed
t-hamano wants to merge 2 commits into
Closed
Block Supports: Ensure that custom CSS is output after the block library styles.#12461t-hamano wants to merge 2 commits into
t-hamano wants to merge 2 commits into
Conversation
…ary styles. Explicitly declare the `wp-block-library` dependency for the `wp-block-custom-css` handle so that `global-styles` is guaranteed to print after it, preventing block default styles from unintentionally overriding global styles. Ports WordPress/gutenberg#80062. Co-Authored-By: Claude <noreply@anthropic.com>
t-hamano
marked this pull request as ready for review
July 9, 2026 15:35
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ramonjd
approved these changes
Jul 12, 2026
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
@westonruter had some doc change suggestions over in WordPress/gutenberg#80062
Just passing by to say LGTM after those are in.
westonruter
approved these changes
Jul 13, 2026
pento
pushed a commit
that referenced
this pull request
Jul 13, 2026
The `wp-block-custom-css` handle depended only on `global-styles`, which pulled `global-styles` forward in the print order, ahead of `wp-block-library`. Block library default styles then printed last and overrode global styles. Declare `wp-block-library` before `global-styles` in the handle's dependency array so `wp-block-library` prints first and `global-styles` keeps winning the cascade. Developed in: #12461 Follow-up to [61678], [62656]. Props ramonopoly, westonruter, wildworks. Fixes #65602. git-svn-id: https://develop.svn.wordpress.org/trunk@62706 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 13, 2026
The `wp-block-custom-css` handle depended only on `global-styles`, which pulled `global-styles` forward in the print order, ahead of `wp-block-library`. Block library default styles then printed last and overrode global styles. Declare `wp-block-library` before `global-styles` in the handle's dependency array so `wp-block-library` prints first and `global-styles` keeps winning the cascade. Developed in: WordPress/wordpress-develop#12461 Follow-up to [61678], [62656]. Props ramonopoly, westonruter, wildworks. Fixes #65602. Built from https://develop.svn.wordpress.org/trunk@62706 git-svn-id: http://core.svn.wordpress.org/trunk@61990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports WordPress/gutenberg#80062.
Trac ticket: https://core.trac.wordpress.org/ticket/65602
Use of AI Tools
I had the AI implement the code, and then I reviewed it myself.