Trac: Escape check run provider names and statuses in the PR status output. - #746
Closed
obenland wants to merge 1 commit into
Closed
Trac: Escape check run provider names and statuses in the PR status output.#746obenland wants to merge 1 commit into
obenland wants to merge 1 commit into
Conversation
…utput. prStatus() pushed the check_runs provider key (a GitHub App name) and its free-text status value into the rendered HTML unescaped, allowing markup to reach container.append() in renderPR(). Escape both with the same jQuery text()/html() idiom already used for the review states, while the switch continues to match on the raw value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the githubPRs module,
prStatus()pushed thecheck_runsprovider key (a GitHub App name) and its free-text status value into the returned string unescaped.renderPR()concatenates that string into the HTML passed tocontainer.append(), so both rendered as markup instead of text.This escapes both values with the same jQuery
$( '<span>' ).text( value ).html()idiom already used for the review states below. Theswitchstill matches on the raw value, so thein_progress/failed/successbehavior is unchanged — only what gets rendered differs.Note: PR #734 rewrites this file wholesale; its branch already carries the equivalent fix in the modernized style (obenland/wordpress.org@7b64e37f4), so whichever lands second resolves the overlap by keeping its own version.
🤖 Generated with Claude Code