Skip to content

fix: reject structured api errors - #816

Open
miachillgood wants to merge 1 commit into
XeroAPI:masterfrom
miachillgood:codex/reject-structured-api-errors
Open

fix: reject structured api errors#816
miachillgood wants to merge 1 commit into
XeroAPI:masterfrom
miachillgood:codex/reject-structured-api-errors

Conversation

@miachillgood

Copy link
Copy Markdown
Contributor

Summary

  • stop re-serializing generated API errors into JSON strings before rejecting
  • keep the existing structured ApiError.generateError() payload so callers receive an object they can inspect
  • add a regression test covering a rejected generated API call

Testing

  • npm test -- --runInBand

Fixes #741.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error thrown is a String

1 participant