Infer object type from additionalProperties - #1823
Open
woohyun-park wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Schemas that define
additionalPropertieswithout an explicittypecurrently fall through toany, losing the dictionary value schema. This is tracked in #1822.Solution
Infer an object schema when
additionalPropertiesis enabled andtypeis absent. Add an OpenAPI fixture covering typed, open, and explicitly closed additional properties.Closes #1822.
Verification
bun run format:checkbunx biome check src/schema-parser/schema-parser.ts tests/spec/additional-properties-without-type/basic.test.ts tests/spec/additional-properties-without-type/schema.jsonbun run test(96 files, 288 tests)bun run buildbun run lintwas also run; it currently reports existing diagnostics in unchanged files. The changed files pass the targeted Biome check above.Written by an agent (OpenAI Codex, GPT-5).
Summary by cubic
Infer object type when
additionalPropertiesis present without atype. This preserves dictionary value schemas and avoids falling back toany.typetoobjectwhenadditionalPropertiesis enabled andtypeis absent.Written for commit 344dcd0. Summary will update on new commits.