fix: use api enable_https for export download node proxy - #663
Merged
Conversation
Cross-node data export downloads always built http:// targets from Request.Proto (HTTP version), so HTTPS clusters failed with 400. Derive scheme from dms.api.enable_https, skip TLS verify for internal proxy, and add download proxy logs plus unit tests.
Seechi-Yolo
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Request.Proto(HTTP version), so targets were alwayshttp://. On HTTPS clusters this returnedClient sent an HTTP request to an HTTPS serverand the UI showed a request error.dms.api.enable_https, useInsecureSkipVerifyfor internal node TLS, and add download/proxy logging.Related CSVW PR: https://github.com/actiontech/dms-ee/pull/959
Test plan
go test -mod=vendor -count=1 ./internal/apiserver/service/ -run 'TestNodeProxyScheme|TestProxyDownloadDataExportTask'go vet -mod=vendor ./internal/apiserver/service/make EDITION=ce docker_installmain-ee