feat: sync KingBase datasource type and default schema to ODC - #666
Merged
Conversation
Map KingBase to KINGBASE, require database_name, and pass it as DefaultSchema when opening the SQL workbench. Co-authored-by: Cursor <cursoragent@cursor.com>
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Seechi-Yolo
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/964
描述你的变更
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docMade with Cursor
Description
添加 KingBase 类型映射与默认 Schema 设置
强制校验 database_name 参数有效性
更新 SQL Workbench 数据源处理逻辑
增加 KingBase 相关单元测试验证
Diagram Walkthrough
File Walkthrough
const.go
更新常量映射增加 KingBase 支持internal/dms/pkg/constant/const.go
sql_workbench_service.go
调整 SQL Workbench 逻辑支持 KingBaseinternal/sql_workbench/service/sql_workbench_service.go
const_test.go
追加 KingBase 测试场景internal/dms/pkg/constant/const_test.go
sql_workbench_service_test.go
添加 KingBase 功能与回归测试internal/sql_workbench/service/sql_workbench_service_test.go