zephyr-cp: add ranges; to three rebuilt partitions nodes - #11271
Open
lynt-smitka wants to merge 1 commit into
Open
zephyr-cp: add ranges; to three rebuilt partitions nodes#11271lynt-smitka wants to merge 1 commit into
lynt-smitka wants to merge 1 commit into
Conversation
Each of these overlays deletes the partitions node its board DTS declares and rebuilds it without re-declaring ranges;. Devicetree then leaves the child addresses untranslated and every partition resolves to a bare offset. On the two RP2040 boards the code partition lands at 0x100 instead of 0x10000100, so RP2_REQUIRES_SECOND_STAGE_BOOT no longer matches, the second stage bootloader is not linked in and the UF2 is built for the wrong address. Same as adafruit#11234, which covered rpi_pico_zephyr. On stm32wba65i_dk1 the partitions resolve to 0x0, 0x10000, 0x108000 and 0x1e0000 rather than 0x08000000 upwards. flash_map computes a mapped partition's offset as DT_REG_ADDR(partition) - DT_REG_ADDR(memory), so every flash_area offset on that board underflows. Each board's own DTS declares ranges; on that node, so this only puts back what the overlay dropped. Partition offsets and sizes are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11234, which fixed rpi_pico_zephyr. Three more overlays have the same problem.
Measured before and after on stm32wba65i_dk1:
Each board's own DTS declares ranges; on the partitions node, so this only restores what the overlay dropped. Offsets and sizes are unchanged.
I swept every overlay in the port that rebuilds a partitions node; these three are the only ones affected.