Fixing some random unks in several Addons - #1936
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most significant one I encountered was AddonNamePlate.DoFullUpdate, this is actually IsInPvPArea and that is cached. However all the nameplates do get updated when this value changes.
Client::UI::RaptureAtkModule_OnUpdate_Nameplates
Client::UI::AddonNamePlate_OnRequestedUpdate
sub_140606730 checks if you're in a custom pvp match or are spectating one
You can check this by going to the Wolves Den or any other PvP area and see that it stays 1, however I would appreciate if someone can doublecheck the whole process for me.
To make up for the rename (and eventual obsolete) I have sigged the method UpdateAllNamePlates that does update all the nameplates.
Some evidence for the other changes:
ffxiv_dx11_2026-08-27_23-06-49.mp4
AI was used for some of the descriptions/summaries.