Skip to content

Fixing some random unks in several Addons - #1936

Merged
Haselnussbomber merged 4 commits into
aers:mainfrom
Zeffuro:misc-addon-unks
Aug 28, 2026
Merged

Fixing some random unks in several Addons#1936
Haselnussbomber merged 4 commits into
aers:mainfrom
Zeffuro:misc-addon-unks

Conversation

@Zeffuro

@Zeffuro Zeffuro commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The most significant one I encountered was AddonNamePlate.DoFullUpdate, this is actually IsInPvPArea and that is cached. However all the nameplates do get updated when this value changes.

Client::UI::RaptureAtkModule_OnUpdate_Nameplates

    Component::GUI::NumberArrayData_SetValueIfDifferent(v2, 0, v4);
    v54 = sub_140606730();
    Component::GUI::NumberArrayData_SetValueIfDifferent(v2, 5, v54);
    v55 = Client::Game::GameMain_IsInPvPArea();
    Component::GUI::NumberArrayData_SetValueIfDifferent(v2, 4, v55);

Client::UI::AddonNamePlate_OnRequestedUpdate

v12 = IntArray[4] == 0;
  v143 = *IntArray;
  v11 = v143;
  this->DoFullUpdate = !v12;
  v132 = !v12;

sub_140606730 checks if you're in a custom pvp match or are spectating one

char sub_140606730()
{
  Client::Game::SpectatorManager *Instance; // rax

  if ( g_Client::Game::Conditions_Instance.ParticipatingInCustomMatch
    || (Instance = Client::Game::SpectatorManager_GetInstance()) != 0 )
  {
    LOBYTE(Instance) = 1;
  }
  return (char)Instance;
}

You can check this by going to the Wolves Den or any other PvP area and see that it stays 1, however I would appreciate if someone can doublecheck the whole process for me.

ffxiv_dx11_2026-08-27_23-20-55

To make up for the rename (and eventual obsolete) I have sigged the method UpdateAllNamePlates that does update all the nameplates.

Some evidence for the other changes:

ffxiv_dx11_2026-08-27_22-30-01 ffxiv_dx11_2026-08-27_22-37-21
ffxiv_dx11_2026-08-27_23-06-49.mp4
ffxiv_dx11_2026-08-27_22-34-13 ffxiv_dx11_2026-08-28_01-45-43

AI was used for some of the descriptions/summaries.

Comment thread FFXIVClientStructs/FFXIV/Client/UI/Misc/RaptureHotbarModule.HotbarSlot.cs Outdated
Comment thread FFXIVClientStructs/FFXIV/Client/UI/Misc/RaptureHotbarModule.HotbarSlot.cs Outdated
Comment thread FFXIVClientStructs/FFXIV/Component/GUI/AtkUldComponentDataBase.cs
@Haselnussbomber
Haselnussbomber merged commit 6c1e479 into aers:main Aug 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants