atecontroller: emit Kubernetes Events from WorkerPool and ActorTemplate reconcilers - #881
Open
Alex Bulankou (AlexBulankou) wants to merge 1 commit into
Conversation
…te reconcilers Neither controller wired an EventRecorder, so reconcile progress and failures were invisible to kubectl describe. Wire record.EventRecorder into both, following the controller-runtime idiom: - WorkerPool: Deleting (Normal), ReconcileFailed (Warning), Synced (Normal - gated behind the existing status-change DeepEqual check so it fires once per real change, not every requeue). - ActorTemplate: golden-actor lifecycle breadcrumbs across the phase machine - GoldenActorCreated / GoldenActorResumed / Ready (Normal), GoldenActorCreateFailed / GoldenActorResumeFailed / GoldenSnapshotFailed (Warning). Signed-off-by: Alex Bulankou <alexbu@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither controller wires a
record.EventRecorder, so reconcile progress and failures never surface inkubectl describe— an undebuggable reconcile loop for operators. This wires one into both controllers, following the controller-runtime idiom already used elsewhere in the operator:Deleting(Normal),ReconcileFailed(Warning),Synced(Normal — gated behind the existing status-changeDeepEqualcheck so it fires once per real change, not on every requeue).GoldenActorCreated/GoldenActorResumed/Ready(Normal), andGoldenActorCreateFailed/GoldenActorResumeFailed/GoldenSnapshotFailed(Warning).go build ./...,go vet, and the controller test suite pass locally.