Add UNSPECIFIED zero value for ActorSnapshotTagScope - #898
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoAug 13, 2026
Merged
Conversation
Luiz Oliveira (laoj2)
requested a review
from Julian Gutierrez Oschmann (juli4n)
August 12, 2026 18:30
Collaborator
|
I don't fully understand why this is necessary? If the default is |
Collaborator
Author
substrate's API style guide (https://github.com/agent-substrate/substrate/blob/main/docs/api-style-guide.md#51-enum-naming) made an explicit decision of requiring
|
Julian Gutierrez Oschmann (juli4n)
approved these changes
Aug 13, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit Aug 13, 2026
5fbfd77
into
agent-substrate:main
11 checks passed
Julian Gutierrez Oschmann (juli4n)
pushed a commit
that referenced
this pull request
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897